dependency injection - A controller that might violate Single Responsibility Principle? -


Refers to this comment,

When a class had a very long list of arguments It may be a "code odor" that is trying to do a lot of your class and is probably not following the single responsibility principle. If your class is trying to do too much, then its code Consider re-implementing in many small classes which consume one another .

What should I do about this controller class below - what is it trying to do "too much"? 

  class controller {public $ template; Public $ translation; Public $ auth; Public $ article; Public $ nav; Public function __ composition (database $ connection, $ template) {$ this- & gt; Template = $ template; $ This- & gt; Translation = New Translator ($ connection); $ This- & gt; Navy = new navy ($ connection); $ This- & gt; Article = new paragraph ($ connection); $ This- & gt; Auth = new Auth ($ connection); } Public function getHtml (if (isset ($ _ request ['url'])) {$ item = $ this-> article- getRow (['url' = & gt; 'home', 'Is_admin' = & gt; $ this-> auth-> i_admin]); $ this-> template- & gt; path;}}}
< P> How can I break it into smaller sections - if it is a controller that keeps these basic classes that I need to output to a page?

And what should I do It follows the principle of principle?

Note: This short version will be because I'm at work. I will expand the evening

So ... the violation has been followed in your code:

  • SRP (more detail - SOC): Your administrator Input, authorization, data collection, preparation of template with data, and verification of rendering is accounted for. Also, your article db abstract and domain arguments both Is responsible for.

  • LoD : You are passing $ connection only because you have given it to other structures Will have to be given on.

  • Encapsulation : All of your class attributes have public visibility and can change at any point.

  • Dependency injection : While your "controller" has many direct dependencies, you only have template (which is not actually managed by the controllers in the appropriate MVC Should go).

  • Global Status : Your code depends on $ _ request superglobal.

  • Loose coupling : Your code is tied directly to the names of sections and the footprint of the consultants for those sections, which you start in the constructor .


-

Comments

Post a Comment

Popular posts from this blog

sqlite3 - UPDATE a table from the SELECT of another one -

I have the first table article where some data is missing. In the table, articles_tmp I have a part of the missing data. So I want to update the articles. Where the path path is data in articles_tmp.path where the path is not zero . With SQLite , it does not work: update article SET path = (SELECT at.path FROM Articles_tmp as AS, WHERE at.article_id = a.id and a.asp, the text is in the form and not on. It has been transmitted) where the path is null MS Access Along with, it works fine: Update Articles Join the Inner Articles at articles_tmp articles.id = articles_tmp.id SETP articles.path = articles_tmp.path Can anyone help? Sin CE SQL Server Syntax, which I provided, was not working, here this solution With whom I have come. A little modification of your original query, but with my "correlation" suggestion added. There is a SQL Bella for this: Here is the code: update article SET path = (SELECT path from articles_tmp AS T WHERE t.id
Read more

c# - Showing a SelectedItem's Property -

So I have enabled a rightclick option for my DataGrid. I want to display the only chosen property but it is not behaving like what I would like it to display my name and additional. Public category Paymentinfo {public int PaymentNo {get; Set; } Public string date {get; Set; } Public Double Pay {get; Set; } Public Double Principle {get; Set; } Public Double Interest {get; Set; } Public Double Balance {Received; Set; }} Private Zero MenuItem_OnClick (Object Sender, RoutedEventArgs e) {MessageBox.Show (AmortGrid.SelectedItem.ToString ()); } I'm trying to apply it without using a View Module! If I place a breakpoint where the messagebox and the recipient place it on selected ITEM, then this property will display the payment. A date-payment-principle-interest-balance is the only value that needs payment. Was hoping that it would be something like this MessageBox.Show (AmortGrid.SelectedItem.PaymentNo.ToString ()); When you call ToString () So you get the class typ
Read more

javascript - Render HTML after each iteration in loop -

I'm trying to gradually increase the font size of text on a web page. The code works in my place, although the new HTML / CSS does not render after every iteration of the loop and when all this is done, then display only the text of 100 px size. To see the text as if it is slowly zooming, I need to do this JavaScript is down because it is being used from a different file here is what I have ... < Pre> & lt; P class = "game-title" style = "font-size: 50px" & gt; Test & lt; / P & gt; Function sleep (milliseconds) {var start = new date (). GetTime (); For (var i = 0; i & lt; 1e7; i ++) {if ((new date). GetTime () - start) & gt; Milliseconds {break; CSS ('font-size', 'parseInt ($ (' game-title '). CSS (' font-size ')) + 1 + "pixels"); } While (parasont ($ ('# text'). Css ('font-size')) & lt; = 100) {sleep (1000); IncreaseSize (); Using CSS: Use of jQuery (sample):
Read more